[SPIP] Hide schedule event in timeline mode #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xurxodev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
⚙️ branches
app:
Origin: ffeature-spip/hide_schedule_event_in_timeline_mode Target: develop-spip
dhis2-android-SDK:
Origin: develop-eyeseetea
🎩 What is the goal?
Only visible add new in time line mode
📝 How is it being implemented?
💥 How can it be tested?
The problem is that in group mode to show schedule event menu uses hideDueDate in program stage. But in timeline mode program stage is null because manage all events without program stage reference, in this case always is creating the menu.
I've removed the menu creation in this case
💾 Requires DB migration?
🎨 UI changes?